CMU-17313Q / NodeBB-f23

GNU General Public License v3.0
0 stars 39 forks source link

Successfully translated file /src/groups/create.js from JS to TS #70

Open FatimaY810 opened 1 year ago

FatimaY810 commented 1 year ago

No errors left with the linter (npm run lint) and all tests passed (rpm run test) with a code coverage of:

Statements : 88.73% ( 21570/24307 ) Branches : 75.78% ( 9089/11993 ) Functions : 90.01% ( 4002/4446 ) Lines : 88.82% ( 20739/23348 )

added multiple interfaces with types declared for all functions and variables of the interface. Additionally declared all types for any constants in the file. There was a need to disable the linter on multiple occasions due to depends on untranslated files.

resolves #20

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6011405248


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/social.js 15 16 93.75%
src/groups/create.js 28 30 93.33%
src/controllers/composer.js 35 40 87.5%
<!-- Total: 78 86 90.7% -->
Files with Coverage Reduction New Missed Lines %
src/messaging/notifications.js 1 96.55%
src/database/mongo/hash.js 2 88.07%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 5912059056: -0.03%
Covered Lines: 22580
Relevant Lines: 25338

💛 - Coveralls