CMU-17313Q / NodeBB-f23

GNU General Public License v3.0
0 stars 39 forks source link

Converted /src/controllers/home.js from JS to TS #89

Open mahasultan opened 1 year ago

mahasultan commented 1 year ago

This pull request shows the translation of the file src/controllers/home.js from javacript to typescript. This PR is in response to issue #38. This process involved the translation, creation of type interfaces for configuration and user settings objects to provide type safety, as well as Introduced try-catch blocks for improved error handling during URL parsing. I also made use of the ' eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call' feature to ensure I could use existing modules that have yet to be translated.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6025474426


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/home.js 52 59 88.14%
<!-- Total: 52 59 88.14% -->
Files with Coverage Reduction New Missed Lines %
src/messaging/notifications.js 1 94.83%
src/database/mongo/hash.js 2 88.07%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 5912059056: -0.02%
Covered Lines: 22624
Relevant Lines: 25383

💛 - Coveralls