search

CMU-17313Q / NodeBB

GNU General Public License v3.0
0 stars 45 forks source link

Refactoring code in src/install.js #3

Open mrahmed2026 opened 2 weeks ago

mrahmed2026 commented 2 weeks ago

https://sonarcloud.io/project/issues?open=AZGVh-Bo4m3Xmlma-BBo&id=CMU-17313Q_NodeBB Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed

src/install.js

mrahmed2026 commented 2 weeks ago

I would like to work on this please!

github-actions[bot] commented 2 weeks ago

Great! I assigned you (@mrahmed2026) to the issue. Have fun working on it!

EduardoFF commented 2 weeks ago

The current tests do not cover this file. Therefore, you have two options to complete the last part of P1B:

(a) Write tests from scratch to cover that file OR (b) Select another file currently covered by tests (under src/) that is NOT fully covered and do the following:

mrahmed2026 commented 1 week ago

Hi Professor, could we please meet today? Im free from 5:15 to 5 30, just to clarify this issue. Thanks, Rayyan Ahmed

On Sun, Sep 1, 2024 at 9:52 PM Eduardo Feo-Flushing < @.***> wrote:

The current tests do not cover this file. Therefore, you have two options to complete the last part of P1B:

(a) Write tests from scratch to cover that file OR (b) Select another file currently covered by tests (under src/) that is NOT fully covered and do the following:

  • Increase the coverage of the file by at least one line.
  • Commit your changes to the same branch referenced in the PR.
  • For the final part of the task (manual testing), activate at least one function of the file you selected from the user interface (UI).

— Reply to this email directly, view it on GitHub https://github.com/CMU-17313Q/NodeBB/issues/3#issuecomment-2323458527, or unsubscribe https://github.com/notifications/unsubscribe-auth/A67AOMJQXL42BLE65ZKNX43ZUNO5FAVCNFSM6AAAAABNH2JFVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGQ2TQNJSG4 . You are receiving this because you were mentioned.Message ID: @.***>