Refactor NodeBB/src/flags.js to reduce Cognitive Complexity from 16 to 15

fdounis commented 2 months ago

This pull request refactors the getFlagIdsWithFilters function in flags.js to address multiple concerns, including reducing Cognitive Complexity and fixing various linting errors. The following changes were made:

Reduced Cognitive Complexity:
- Extracted filter initialization logic into a new initializeFilters function to separate concerns.
- Created a buildSets function to encapsulate the logic for constructing sets and orSets, improving the readability of the main function.
- Extracted the logic for fetching flag IDs based on sets into a new getFlagIdsFromSets function.
- Separated the processing of orSets into two functions: getFlagIdsFromOrSets to handle retrieval and mergeFlagIds to handle the merging logic, reducing nested conditions and overall complexity.
Fixed Linting Errors:
- Removed unnecessary parentheses around single arguments in arrow functions (specifically in the getFlagIdsFromOrSets function).
- Adjusted line breaks to eliminate unexpected line breaks before expressions and to comply with style rules.
- Corrected unexpected newlines before closing parentheses in function calls, ensuring proper formatting and adherence to style guidelines.
- Eliminated an unnecessary else statement after a return, as the else was redundant and removed to streamline the code.