CMU-17313Q / NodeBB

GNU General Public License v3.0
0 stars 50 forks source link

Reduce cognitive complexity in src/controllers/helpers.js #66

Open aattiyah opened 2 months ago

aattiyah commented 2 months ago

I refactored the code in this file to reduce its cognitive complexity from 20 to the 15 allowed. I did this by adding a helper function handleSuccessfulResponse.

Resolves issue #34

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10677270369

Details


Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 83.72%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10550029021: 0.003%
Covered Lines: 22325
Relevant Lines: 25584

💛 - Coveralls