coveralls
commented
2 weeks ago Pull Request Test Coverage Report for Build 10720589831
Details
- 25 of 26 (96.15%) changed or added relevant lines in 1 file are covered.
- 2 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.02%) to 82.69%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/controllers/mods.js | 25 | 26 | 96.15% | ||
| <!-- | Total: | 25 | 26 | 96.15% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/controllers/mods.js | 2 | 76.03% | ||
| <!-- | Total: | 2 | --> |
| Totals | |
|---|---|
| Change from base Build 10550029021: | 0.02% |
| Covered Lines: | 22336 |
| Relevant Lines: | 25592 |
sonarcloud[bot]
Resolves #39
I refactored code in src/controllers/mods.js to reduce cognitive complexity which was 20.
Several helper functions were added to make the code easier to read and simpler to debug. The helper functions are as follows:
initialize(req): Sets up needed data. checkAccess(...): Checks user permissions and updates local variables. parseFilters(req, filters): Processes filter parameters from the request. adjustFiltersForMod(filters, res): Updates filters based on moderation. determineHasFilter(filters): Checks if filters are applied. parseSort(req, sorts): Handles sorting parameters. fetchData(req, filters, sort): Retrieves the required data. getSelectedUsers(filters): Gets user details for selected filters.