CMU-17313Q / NodeBB

GNU General Public License v3.0
0 stars 50 forks source link

Decreased nesting levels in function (src/topics/sorted.js) #82

Open rmmahmou opened 2 months ago

rmmahmou commented 2 months ago

This pull request resolves https://github.com/CMU-17313Q/NodeBB/issues/23 as it will decrease the depth of nesting of a 5-level function declaration by extracting some functions out of the containing function.

Changes were tested using the npm run lint and npm run test commands.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10698927097

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/topics/sorted.js 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10550029021: -0.007%
Covered Lines: 22322
Relevant Lines: 25583

💛 - Coveralls