search

CMU-17313Q / NodeBB

GNU General Public License v3.0
0 stars 45 forks source link

Refactoring code in src/batch.js #9

Open Hakaabi opened 2 weeks ago

Hakaabi commented 2 weeks ago

I am refactoring the function 'processSortedSet' in file 'batch.js' under folder 'src'.

I added a helper function named 'processIsFunction' to deal with the cognitive complexity warning from line 17. This single helper method was able to solve all the errors concerning cognitive complexity in the code.

NodeBB version

No response

NodeBB git hash

No response

NodeJS version

No response

Installed NodeBB plugins

No response

Database type

No response

Database version

No response

Exact steps to cause this issue

No response

What you expected

No response

What happened instead

No response

Anything else?

No response

Hakaabi commented 2 weeks ago

I would like to work on this please!

github-actions[bot] commented 2 weeks ago

Great! I assigned you (@Hakaabi) to the issue. Have fun working on it!

EduardoFF commented 2 weeks ago

This type of issue shouldn't be labeled as a bug. It pertains to solving a problem that affects code quality rather than functionality.