Refactor public/src/client/account/info.js to address SonarCloud warning - Githubissues

CMU-313 / NodeBB

GNU General Public License v3.0

0 stars 223 forks source link

Refactor public/src/client/account/info.js to address SonarCloud warning #506

Open sofian-syed opened 2 months ago

sofian-syed commented 2 months ago

This PR addresses issue #357 authored by me (Sofian Syed). The SonarCloud warning regards code that has more than 4 levels of nested functions in the public/src/client/account/info.js file. The following changes were made:

Abstracted deeply nested functions into separate functions outside the larger function.
Updated event handlers (onclick handlers) to use the new, refactored functions. The refactored code has been linted, and all tests pass successfully. Please review the code changes and merge this PR to main.

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10710469907

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.671%

Totals
Change from base Build 10607818019:	0.0%
Covered Lines:	22323
Relevant Lines:	25582

💛 - Coveralls