CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 224 forks source link

Refactor Code in public/src/admin/admin.js #520

Open lukenalewajk opened 2 months ago

lukenalewajk commented 2 months ago

The function call here is 5 levels deep, when the threshold is 4 functions deep. The code must be refactored in order to improve readability and maintainability. This is different that #408 because this function call is in line 186 not 36

https://sonarcloud.io/project/issues?directories=public%2Fsrc%2Cpublic%2Fsrc%2Fadmin%2Cpublic%2Fsrc%2Fadmin%2Fextend%2Cpublic%2Fsrc%2Fadmin%2Fmanage%2Cpublic%2Fsrc%2Fclient%2Cpublic%2Fsrc%2Fclient%2Faccount%2Cpublic%2Fsrc%2Fclient%2Fcategory%2Cpublic%2Fsrc%2Fclient%2Fchats%2Cpublic%2Fsrc%2Fclient%2Fgroups%2Cpublic%2Fsrc%2Fclient%2Ftopic%2Cpublic%2Fsrc%2Fmodules%2Cpublic%2Fsrc%2Fmodules%2Faccounts%2Cpublic%2Fsrc%2Fmodules%2Fsettings%2Csrc%2Csrc%2Fapi%2Csrc%2Fcategories%2Csrc%2Fcli%2Csrc%2Fcontrollers%2Csrc%2Fcontrollers%2Faccounts%2Csrc%2Fcontrollers%2Fadmin%2Csrc%2Fdatabase%2Csrc%2Fdatabase%2Fmongo%2Csrc%2Fdatabase%2Fpostgres%2Csrc%2Fdatabase%2Fredis%2Csrc%2Fgroups%2Csrc%2Fmessaging%2Csrc%2Fmeta%2Csrc%2Fmiddleware%2Csrc%2Fplugins%2Csrc%2Fposts%2Csrc%2Fprivileges%2Csrc%2Froutes%2Csrc%2Fsocket.io%2Ftopics%2Csrc%2Ftopics%2Csrc%2Fupgrades%2F1.0.0%2Csrc%2Fuser&issueStatuses=OPEN%2CCONFIRMED&id=CMU-313_NodeBB&open=AZFmi_6dybYwxy-_uEVG&tab=code

lukenalewajk commented 2 months ago

I would like to work on this please!

github-actions[bot] commented 2 months ago

Great! I assigned you (@lukenalewajk) to the issue. Have fun working on it!