Refactor code in public/src/admin/settings/navigation.js

zzzannie commented 2 months ago

This PR resolves #533 .

The SonarCloud raised warning “refactor this code to not nest functions more than 4 levels deep” in public/src/admin/settings/navigation.js at line 100
To address the warning, a helper function was added inside the nested function to reduce levels
The changes passed linter and test suite, and were executed by UI operations with frontend console logs

Further notes on my attempts:

The first issue I tried was #468 ; however, after I passed all checks and tried with the UI operations, I realized there were no UI operations for upgrade
The second issue I tried was #515 ; however, when I was addressing the warning, I got a warning NODE_TLS_REJECT_UNAUTHORIZED and wasn't able to fixed it, even cloning again didn't help, so I deleted my fork and restarted
For this current issue I resolved, public/src/admin/settings/navigation.js wasn't covered by the testing files; there was even no folder for public/src/admin/settings to add tests