CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 223 forks source link

. #537

Closed jullia02 closed 2 months ago

jullia02 commented 2 months ago

Refactored function in settings.js to reduce cognitive complexity from 17 to 15. This was done by breaking down the savesettings() function into smaller functions to improve readability.

This PR resolves , with the sonar cloud warning: https://sonarcloud.io/project/issues?open=AZFmi_ySybYwxy-_uEQC&id=CMU-313_NodeBB

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10726967242

Details


Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10607818019: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud