Refactored code in scr/flags.js to reduce the cognitive complexity from 27 to 15

zhanwen22 commented 2 months ago

In the function Flags.update located in scr/flags.js there was a cognitive complexity issue due to the overly nested code and many unnecessary if statements. This was fixed by breaking down a big function into smaller functions and reducing or statements, ultimately leading to cleaner code.

Edit to add: TA told me that my coverage was ok, because it was from a file that I did not work on. So I reverted my test cases to the original ones, because that caused the least SonarCloud errors.

This resolves https://github.com/CMU-313/NodeBB/issues/519 with the SonarCloud issue: https://sonarcloud.io/project/issues?cleanCodeAttributeCategories=ADAPTABLE&directories=src&impactSeverities=HIGH&impactSoftwareQualities=MAINTAINABILITY&issueStatuses=OPEN%2CCONFIRMED&id=CMU-313_NodeBB&open=AZFmjARHybYwxy-_uEfu&tab=code