CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 223 forks source link

Refactored code in public/src/admin/settings.js #557

Open kmehta5 opened 2 months ago

kmehta5 commented 2 months ago

Refactored handleUploads function in public/src/admin/settings.js by unnesting functions and writing them as separate functions. resolves #541. The functions that resulted from this were : handleClick, getUploaderOption, updateTargetValue.

My coverall is failing by .005% because of a decrease in coverage in the src/meta/errors.js file. This is not a file I addressed at all in my refactoring and it is not related to my refactored code. TAs on Thursday let me know that this was ok as long as I acknowledged and explained it.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10727405075

Details


Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10607818019: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls