CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 223 forks source link

Fixed complexity issues of src/notifications.js #560

Open LastSymphony12 opened 2 months ago

LastSymphony12 commented 2 months ago

Reduced two blocks of code: Notifications.forEach and Differentiators.forEach. These functions have been passed through the lint and test functions, resulting in no errors and 87.06% coverage respectively. Console Log Testing wasn’t possible, as my local system was unable to run those. This is related to issue #297

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 11506334754

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/notifications.js 8 12 66.67%
<!-- Total: 8 12 66.67% -->
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10607818019: 0.007%
Covered Lines: 22325
Relevant Lines: 25584

💛 - Coveralls
sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud