search

CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 223 forks source link

Refactored code in src/upgrades/1.4.4/sound_settings.js #566

Open sophiefeng18 opened 2 months ago

sophiefeng18 commented 2 months ago

Refactored this code to not nest functions more than 4 levels deep. Resolves issue #561

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10728601270

Details

Totals Coverage Status
Change from base Build 10607818019: 0.02%
Covered Lines: 22328
Relevant Lines: 25582
💛 - Coveralls
sophiefeng18 commented 2 months ago

The existing testing framework does not include tests similar to what my refactored code needs. My refactored code allows the users to update their sound settings for notification, incoming chat, and outgoing chat. However, the existing testing framework does not have tests for sounds or settings adjustment on the users' end.