Refactored code in public/src/client/account/settings.js to reduce complexity.

[jullia02]

This PR refactors the saveSettings() function in settings.js, reducing cognitive complexity from 17 to 15 to improve readability and for simplicity. This was done by making multiple helper functions handleNewSettings(), processNewSettings(), and checkAndUpdateConfig().

This PR resolves #570, with the sonar cloud warning: https://sonarcloud.io/project/issues?open=AZFmi_ySybYwxy-_uEQC&id=CMU-313_NodeBB

This refactored code is covered by the test file: ./test/public/src/settings.js

UI Test Instructions

1. Click on profile icon on top right.
2. Click on Settings
3. Change either the language/skin/home page setting.
4. Click on "Save changes". This should print the console log message.

[coveralls]

Pull Request Test Coverage Report for Build 10730309223

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 82.671%

---

Totals
Change from base Build 10607818019:	0.0%
Covered Lines:	22323
Relevant Lines:	25582

---

💛 - Coveralls

[sonarcloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud