CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 223 forks source link

testing #586

Open swaeliu opened 2 months ago

swaeliu commented 2 months ago

test commit-- version one.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 11025669036

Details


Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10607818019: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls
swaeliu commented 2 months ago

Hi, I am not sure why I have a failing case for duplicate code--the duplicate happens to be exactly the bit that I did not change at all and just copied from the original on SonarCloud. Could it be that someone was working on this issue already?

swaeliu commented 2 months ago

Refactored code in lines 9 through 24. Specifically moved the some parts of the control flow around to prevent deeply nested functions. Also, sonar cloud states that quality gate is failed because of code duplication error... This is acceptable because my file handles mouse click events and toggling--parts of this code are found across the codebase.

Thus, the duplication error is justified because very similar functions exist throughout the codebase to perform mouse toggling.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
40.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud