Open swaeliu opened 2 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/meta/errors.js | 1 | 76.74% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 10607818019: | -0.005% |
Covered Lines: | 22322 |
Relevant Lines: | 25582 |
Hi, I am not sure why I have a failing case for duplicate code--the duplicate happens to be exactly the bit that I did not change at all and just copied from the original on SonarCloud. Could it be that someone was working on this issue already?
Refactored code in lines 9 through 24. Specifically moved the some parts of the control flow around to prevent deeply nested functions. Also, sonar cloud states that quality gate is failed because of code duplication error... This is acceptable because my file handles mouse click events and toggling--parts of this code are found across the codebase.
Thus, the duplication error is justified because very similar functions exist throughout the codebase to perform mouse toggling.
Failed conditions
40.7% Duplication on New Code (required ≤ 3%)
test commit-- version one.