search

CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 223 forks source link

Refractor public/src/admin/manage/registration.js so there is nothing nested more than 4 levels deep #588

Open RDNoodles6 opened 2 months ago

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10890020357

Details

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10607818019: -0.005%
Covered Lines: 22322
Relevant Lines: 25582
💛 - Coveralls
RDNoodles6 commented 2 months ago

Refactored function in registration.js so that there are no nested functions more than 4 levels deep in order to better the readability of the file.

Resolves #428

Warning: https://sonarcloud.io/project/issues?fileUuids=AZFmi_dqybYwxy-_uD76&issueStatuses=OPEN%2CCONFIRMED&id=CMU-313_NodeBB&open=AZFmi_4TybYwxy-_uET1

The code was changed from original: image to final -> image

RDNoodles6 commented 2 months ago

Coverage decreases by a little bit which causes coverage test to fail

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud