CMU-313 / NodeBB

GNU General Public License v3.0
0 stars 223 forks source link

Refactored Code in public/src/admin/extend/widgets.js #589

Closed dhanya-cmu closed 2 months ago

dhanya-cmu commented 2 months ago

This PR resolves #554, with the following sonar cloud warning: https://sonarcloud.io/project/issues?open=AZHAkAeb1341_VbvRHcj&id=dhanya-cmu_NodeBB

The code was refactored to not nest functions more than 4 levels deep. This was done by splitting up the problematic function and moving it outside the body of a main function.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10731779410

Details


Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10607818019: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls