CMU-313 / spring23-nodebb-team-a1

spring23-nodebb-team-a1 created by GitHub Classroom
GNU General Public License v3.0
5 stars 2 forks source link

Add Create Tag frontend functionalities #13

Closed teresa0605 closed 1 year ago

teresa0605 commented 1 year ago

9

Added Create Tag frontend functionalities in the themes/nodebb-theme-persona/templates/tags.tpl file. Passed all linter tests

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4174396679


Files with Coverage Reduction New Missed Lines %
src/admin/versions.js 1 83.33%
src/controllers/admin/dashboard.js 2 85.26%
src/database/mongo/sorted.js 2 92.7%
src/middleware/admin.js 2 71.54%
<!-- Total: 7 -->
Totals Coverage Status
Change from base Build 4148497120: -0.02%
Covered Lines: 22609
Relevant Lines: 25375

💛 - Coveralls
teresa0605 commented 1 year ago

This issue is not resolved by the pull request. Backend hasn't been implemented. The original milestone goal was to implement both the frontend and the backend. However, understanding the codebase took me too much time, and I also was sick since Thursday. In our original plan, Will needs to wait on my change to the backend to start translating the files. Since I was not able to complete that, he had limited time to do his work. We will continue to work on this issue for the second sprint.

teresa0605 commented 1 year ago

The JavaScript codes included in the tpl file will be translated in sprint two due to time constraint. I have tried moving the code to another file, but the attempt wasn't successful.