search

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

Wrong Zoom Extents for layer loaded directly after Himawari 8 in a story #148

Closed jjkohler closed 3 years ago

jjkohler commented 3 years ago

(confirmed on dotmaps and landsat - less clear on choropleths) When Himawari 8 (19 of Top 50) is loaded in story view, the next layer chosen does not zoom to its expected level, but instead pauses zoom at some wider extent. The second waypoint loaded (or the original one clicked again) corrects the issue, but it returns each time Himawari is visited.

Incorrect view after Himawari 8 image

Correct view image

rsargent commented 3 years ago

Fixed with commit 9b6db402f1e7856d90b06c699da284b4e19f5957

rsargent commented 3 years ago

Looks like it's confirmed fixed on staging.earthtime.org for clicking waypoints, but not fixed for changing URL hash, which is a different code path. hal44 test shows this for staging.earthtime.org: image

pdille commented 3 years ago

How are you all changing the URL hash? If I manually go between the share links (by typing in the address bar) of waypoint 19 and 20, it warps me to each point with the correct view/zoom.

pdille commented 3 years ago

Is this still an issue? @hjhawkinsiv @rsargent

hjhawkinsiv commented 3 years ago

It does not appear so for Hill 2010 (20/50), however for Bpop 1990-2010 (36/50) this still appears to be the case. This layer follows Himawari 8 (35/50).

image

jjkohler commented 3 years ago

No evidence of this still occurring in actual site use. This seems at worst a testing issue. Closing unless concrete evidence re-emerges.