search

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

Shared Tool can get stuck generating incorrect links #151

Closed jjkohler closed 3 years ago

jjkohler commented 4 years ago

Still working to isolate conditions in which this takes place.

Notice how same link is being generated regardless of which option is chosen: image

image

https://staging.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=26.3011,35.85032,2.815,latLng&t=1.19&ps=100&l=bdrk,ar&bt=20000101&et=20161231&startDwell=0&endDwell=0

pdille commented 3 years ago

This should be addressed in commit 179b18c407. Please confirm.

You should only be offered those specific share options when the waypoint slider is actually visible, otherwise they make no sense.

jjkohler commented 3 years ago

While this fix brought awareness to other smaller issues, this original issue has been fixed and will now be closed.