Closed jjkohler closed 3 years ago
Link contains both bdrk and bdrk_detailed; need to prioritize bdrk_detailed by increasing draw order
@jjkohler
Added Draw Order column to default spreadsheet and defined the value for _bdrkdetailed to be 110.
Appears to have fixed the problem.
Please confirm.
Expanding this to "Deal with prioritizing basemaps to preserve old sharelink behavior".
Assign 100-199 in order to prioritize what's on top, according to the old drawing order from index.html and spreadsheet.
(index.ts should already have code to disable basemaps drawn below other basemaps.)
@jjkohler
All layers categorized as Base Maps in the Default spreadsheet and the Davos 2019 spreadsheet have had a Draw Order added that increases monotonically according to its position in the spreadsheet.
Should be fixed in 298e6470b9 Please confirm.
Based on the cases that I'm aware of, this fix seems to have "fixed" the issue. Current fix allows for bdrk_detailed to be shown above bdrk, even if it appears earlier in the sharelink than bdrk.
Staging
https://staging.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=40.4479,-79.94045,10.183,latLng&t=8.2&ps=50&l=bdrk_detailed,bdrk,pa_redlining_pgh_choropleth&bt=19360101&et=20201231&startDwell=0&endDwell=0
Golden
https://golden.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=40.45996,-79.94734,10.156,latLng&t=0&ps=50&l=bdrk_detailed,bdrk,pa_redlining_pgh_choropleth&bt=19360101&et=20201231&startDwell=0&endDwell=0