Difference in color/styling of coral reef layer

[jjkohler]

22 of Top 50

Staging https://staging.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=10.04219,124.64377,6.908,latLng&t=2.52&ps=50&l=blsat,coral_only,cb&bt=19840101&et=20161231&startDwell=0&endDwell=0

Golden https://golden.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=9.91198,124.31699,7.044,latLng&t=4.8&ps=50&l=blsat,cb&bt=19360101&et=20201231&startDwell=0&endDwell=0

Less saturated color. Was this an intended change?

[pdille]

I had added this layer back and likely didn't pick the exact same color. It's possible this was a specific shader before (which had a hardcoded color) but now we are using a generic line string shader which wants to know a color.

[gabrielo]

@jjkohler These should be an exact match. Please confirm and close if you agree.

[jjkohler]

@gabrielo The color seems to be the same now. There's still a difference in the drawing precision between the two layers. Staging version has less smooth lines (particularly visible on diagonal lines) Staging:

Golden:

Is there a reason for this drawing difference?

[gabrielo]

There are a number of context differences between staging and golden.

staging alpha: true antialias: false depth: true desynchronized: false failIfMajorPerformanceCaveat: false powerPreference: "default" premultipliedAlpha: true preserveDrawingBuffer: false stencil: true xrCompatible: false

golden alpha: true antialias: true depth: true desynchronized: false failIfMajorPerformanceCaveat: false powerPreference: "default" premultipliedAlpha: true preserveDrawingBuffer: false stencil: false xrCompatible: false

Changing these context values for a WebGL context running on golden results in similar problems in the way the lines are drawn. Nite though I believe these new context values are required for the MapBox integration.

[jjkohler]

@gabrielo Thanks. I thinks this merits a discussion with the group.

[rsargent]

It looks like Mapbox layers should work fine with antialiasing turned on. So I think we can turn it back on in index.ts and things will be back to normal :-).

References: https://github.com/mapbox/mapbox-gl-js/issues/7543 https://docs.mapbox.com/mapbox-gl-js/example/custom-style-layer/

On Wed, Oct 21, 2020 at 10:00 AM jjkohler notifications@github.com wrote:

@gabrielo https://github.com/gabrielo Thanks. I thinks this merits a discussion with the group.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CMU-CREATE-Lab/data-visualization-tools/issues/155#issuecomment-713598835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPJ46TOJ57W7G3TX3M5LLSL3SOZANCNFSM4SQXGRSA .

[gabrielo]

I'm not 100% sure that its the context differences. Doing some side-by-side comparisons.

[gabrielo]

@jjkohler original webgl context defaults restored with commit 0f5ff796737a2f313071b6e1e9770e0048dbfd8e.

Please confirm via https://staging.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=10.24934,124.34322,9.834,latLng&t=0.83&ps=50&l=blsat,coral_only,cb&bt=19840101&et=20161231&startDwell=0&endDwell=0

https://golden.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=10.24934,124.34322,9.834,latLng&t=0.83&ps=50&l=blsat,cb&bt=19840101&et=20161231&startDwell=0&endDwell=0

[jjkohler]

Original behavior appears to have been restored