search

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

sitc layer functions from CSV sheet not working #163

Closed rsargent closed 3 years ago

pdille commented 3 years ago

LayerFactory.ts:31 Uncaught (in promise) Error: Cannot find setData function "WebGLVectorTile2.prototype._setSitc4r2Data" at Function.getFunction (LayerFactory.ts:993) at LayerFactory.createLayer (LayerFactory.ts:324) at LayerProxy._loadFromLayerdef (LayerProxy.ts:93) at LayerProxy._load (LayerProxy.ts:84)

pdille commented 3 years ago

Previous lookup tables for reference:

const LOAD_DATA_FUNCTION_LOOKUP_TABLE = {
  "WebGLVectorTile2.prototype._loadData": WebGLVectorTile2.prototype._loadData,
  "WebGLVectorTile2.prototype._loadGeojsonData": WebGLVectorTile2.prototype._loadGeojsonData,
  "WebGLVectorTile2.prototype._loadSitc4r2Data": WebGLVectorTile2.prototype._loadSitc4r2Data,
  "WebGLVectorTile.prototype._loadSitc4r2Data": WebGLVectorTile2.prototype._loadSitc4r2Data, // Supporting typos 4evah
  "WebGLVectorTile2.prototype._loadCarbonPriceRiskDataFromCsv": WebGLVectorTile2.prototype._loadCarbonPriceRiskDataFromCsv,
  "WebGLVectorTile2.prototype._loadBubbleMapDataFromCsv": WebGLVectorTile2.prototype._loadBubbleMapDataFromCsv,
  "WebGLVectorTile2.prototype._loadChoroplethMapDataFromCsv": WebGLVectorTile2.prototype._loadChoroplethMapDataFromCsv,
  "WebGLVectorTile2.prototype._loadBivalentBubbleMapDataFromCsv": WebGLVectorTile2.prototype._loadBivalentBubbleMapDataFromCsv,
  "WebGLVectorTile2.prototype._loadBivalentBubbleMapDataFromCsv": WebGLVectorTile2.prototype._loadBivalentBubbleMapDataFromCsv,
  "WebGLVectorTile2.prototype._loadWindVectorsData": WebGLVectorTile2.prototype._loadWindVectorsData
};

const SET_DATA_FUNCTION_LOOKUP_TABLE = {
  "WebGLVectorTile2.prototype._setSitc4r2Buffer": WebGLVectorTile2.prototype._setSitc4r2Buffer,
  "WebGLVectorTile2.prototype._setPolygonData": WebGLVectorTile2.prototype._setPolygonData,
  "WebGLVectorTile2.prototype._setPointData": WebGLVectorTile2.prototype._setPointData,
  "WebGLVectorTile2.prototype._setLineStringData": WebGLVectorTile2.prototype._setLineStringData,
  "WebGLVectorTile2.prototype._setExpandedLineStringData": WebGLVectorTile2.prototype._setExpandedLineStringData,
  "WebGLVectorTile2.prototype._setIomIdpData": WebGLVectorTile2.prototype._setIomIdpData,
  "WebGLVectorTile2.prototype._setColorDotmapData": WebGLVectorTile2.prototype._setColorDotmapData,
  "WebGLVectorTile2.prototype._setObesityData": WebGLVectorTile2.prototype._setObesityData,
  "WebGLVectorTile2.prototype._setVaccineConfidenceData": WebGLVectorTile2.prototype._setVaccineConfidenceData,
  "WebGLVectorTile2.prototype._setBufferData": WebGLVectorTile2.prototype._setBufferData,
  "WebGLVectorTile2.prototype._setBuffers": WebGLVectorTile2.prototype._setBuffers,
  "WebGLVectorTile2.prototype._setWindVectorsData": WebGLVectorTile2.prototype._setWindVectorsData,
  "WebGLVectorTile2.prototype._setTrajectoriesData": WebGLVectorTile2.prototype._setTrajectoriesData,
  "WebGLVectorTile2.prototype._setAnimatedPointsData": WebGLVectorTile2.prototype._setAnimatedPointsData,
  "WebGLVectorTile2.prototype._setTriangleData": WebGLVectorTile2.prototype._setTriangleData,
  "WebGLVectorTile2.prototype._setGlyphData": WebGLVectorTile2.prototype._setGlyphData,
  "WebGLVectorTile2.prototype._setAnimatedGlyphData": WebGLVectorTile2.prototype._setAnimatedGlyphData
}
pdille commented 3 years ago

Note also that the method is _setSitc4r2Buffer on golden but now _setSitc4r2BufferData on staging. And of course note what the actual error is calling for: _setSitc4r2Data ... (3 different ones apparently?)

gabrielo commented 3 years ago

@jjkohler sitc point flows should be working.

County moves layer (and others of same type) not drawing #149

Is a slightly different problem.

jjkohler commented 3 years ago

Is everyone happy to close this issue yet? @pdille @rsargent or are there still more cases to be dealt with?

gabrielo commented 3 years ago

@jjkohler Compare the below examples that represent the two types of sitc flow layers. https://staging.earthtime.org/explore#v=-1.78111,0,-0.156,latLng&t=1.43&ps=50&l=bdrk,un_population_migration_data_flows&bt=19910101&et=20171231&startDwell=0&endDwell=0 https://golden.earthtime.org/explore#v=-1.78111,0,-0.156,latLng&t=1.43&ps=50&l=bdrk,un_population_migration_data_flows&bt=19910101&et=20171231&startDwell=0&endDwell=0

https://staging.earthtime.org/explore#v=22.05212,19.45411,0.843,latLng&t=0&ps=50&l=bdrk,sitc4r2_commodities_042&bt=20000101&et=20141231&startDwell=0&endDwell=0 https://golden.earthtime.org/explore#v=22.05212,19.45411,0.843,latLng&t=0&ps=50&l=bdrk,sitc4r2_commodities_042&bt=20000101&et=20141231&startDwell=0&endDwell=0

jjkohler commented 3 years ago

Seems like this issue has been resolved