Lower Hill Historical Images not loading

jjkohler commented 4 years ago

https://staging.earthtime.org/explore#waypoints=1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.0&v=40.44217,-79.99072,14.5,latLng&t=0&ps=50&l=bdrk_detailed&bt=0.03&et=2.03&startDwell=0&endDwell=0

pdille commented 4 years ago

We previously had this code to change the projection for this layer:

var view = timelapse.getView();

var p = timelapse.getProjection();
var offset = p.latlngToPoint({
  "lat": 40.44945971297983,
  "lng": -80.00253546388332
});

var longEast = -79.97771966607753;
var longWest = -80.00253546388332;
var timelapse2map = (lowerHillTimemachineLayer.getWidth()/(longEast-longWest)) / (landsatBaseMapLayer.getWidth()/360);
view.scale /= timelapse2map;

view.x = timelapse2map * (view.x - offset.x);
view.y = timelapse2map * (view.y - offset.y);

lowerHillTimemachineLayer.draw(view, tileViewVisibility);

pdille commented 3 years ago

Should be fixed in commit 98b98c8d5457 Please confirm.

Credit to @rsargent for this!

rsargent commented 3 years ago

Paul and I also managed to crop out the tile margin from display by changing vertex and texture coords. This removes the large margins on the right and bottom, which were impacting the Hill video and temp anomaly video, and perhaps more.

On Wed, Nov 4, 2020 at 4:06 PM pdille notifications@github.com wrote:

Should be fixed in commit 98b98c8 https://github.com/CMU-CREATE-Lab/data-visualization-tools/commit/98b98c8d54579d6e2d789c7b276aae13def35c64 Please confirm.

Credit to @rsargent https://github.com/rsargent for this!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CMU-CREATE-Lab/data-visualization-tools/issues/167#issuecomment-721975028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPJ42254KW3TH2OYHFZUTSOG64NANCNFSM4TCK6MWA .

jjkohler commented 3 years ago

Since frame skipping is beyond the scope of this issue, we'll close it and consider revisiting the frame issue at a later point.

CMU-CREATE-Lab / data-visualization-tools

Lower Hill Historical Images not loading #167