search

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

Plume layers throw a shader error on initialization #178

Closed pdille closed 3 years ago

pdille commented 3 years ago

Current: https://staging.earthtime.org/explore#v=40.38189,-79.87507,9.974,latLng&t=27.73&ps=50&l=blte,plume_20190301&bt=201905100400&et=201905200350&startDwell=0&endDwell=0

Expected: https://golden.earthtime.org/explore#v=40.38189,-79.87507,9.974,latLng&t=27.73&ps=50&l=blte,plume_20190301&bt=201905100400&et=201905200350&startDwell=0&endDwell=0

Note: This layer takes a long time to load, which is to be expected.

Error given on staging:

Uncaught (in promise) Error: Cannot find shader function "WebGLVectorTile2.particleAltFadeVertexShader" at Function.getShader (LayerFactory.ts:970) at overrideDrawingFns (LayerFactory.ts:251) at LayerFactory.createLayer (LayerFactory.ts:326) at LayerProxy._loadFromLayerdef (LayerProxy.ts:93) at LayerProxy._load (LayerProxy.ts:84)

gabrielo commented 3 years ago

golden fails for me as well with the following in console: image

gabrielo commented 3 years ago

@pdille @jjkohler Further the shaders specified WebGLVectorTile2.particleAltFadeVertexShader and WebGLVectorTile2.particleAltFadeFragmentShader do not appear to be in the source code of the master branch as actual shaders. See https://github.com/CMU-CREATE-Lab/data-visualization-tools/blob/master/examples/webgl-timemachine/WebGLVectorTile2.js

Do you have an example of a (sub)domain where these work?

gabrielo commented 3 years ago

@jjkohler Shaders added to refactor branch with commit eb119e7e90e59bcc94b25c112da23c27b8f4d777.

Note this never worked on golden only on headless-rsargent.

jjkohler commented 3 years ago

This appears to have been fixed.