search

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

Add back icon for layer description (from markdown in the layer def spreadsheet) #185

Closed jjkohler closed 3 years ago

jjkohler commented 3 years ago

Expected Behavior image

Staging Behavior image

It is possible that the question marks will be replaced with an (i) instead of the (?)

jjkohler commented 3 years ago

Determined to be duplicated by #202 so that issue was close while this one left open

pdille commented 3 years ago

@gabrielo

Right now the only way to get the layer description info is to do a request of a full layer and get back all the information about it.

Could we add a new api request to return just the description?

Right now to get a layer we do:

https://api.earthtime.org/layer-catalogs/1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.74523005/layers/blsat

Perhaps a proposed way to get just a layer description would be:

https://api.earthtime.org/layer-catalogs/1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.74523005/layers/blsat/description

gabrielo commented 3 years ago

@pdille https://api.earthtime.org/layer-catalogs/1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.74523005/layers/blsat/layer_description

pdille commented 3 years ago

Awesome, many thanks!!

I'm gonna be that guy though and bring up the fact that we have both "-" and "_" in the API now.

"layer-catalogs" "layer_description"

I also believe nearly all layer ids make use of "_" but that itself is its own topic.

Could we standardize on one for the db API?

gabrielo commented 3 years ago

@pdille Excellent point.

API uses a "-" now instead of "_". https://api.earthtime.org/layer-catalogs/1heLmeuPp7j4itr0cK8H4chugOpp7cU8p_VEB9CFfPlY.74523005/layers/blsat/layer-description

jjkohler commented 3 years ago

This functionality has now been restored. Nay, (i)improved!