search

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

Default Base Layers Not Loading along with data layers #186

Closed jjkohler closed 3 years ago

jjkohler commented 3 years ago

When manually loading layers from the Data Library in Staging, default base layers are not loaded or honored. This allows for loading of most layers without any background, unless a user manually activates a base layer from the menu.

rsargent commented 3 years ago

(The spreadsheet currently specifies a desired basemap for each layer, and it's not being honored.)

rsargent commented 3 years ago

I just added a Base layer column to the dotmaps sheet tab and populated with "bdrk_subtle", so census dotmap layers are correctly reporting Base layer from api.earthtime.org. @pdille @gabrielo @arwright @jjkohler @hjhawkinsiv

pdille commented 3 years ago

Should be addressed in commit af3bd39c

@jjkohler @hjhawkinsiv As discussed, re-implementing this could have caused regressions. Please test this rigorously in your test suite.

rsargent commented 3 years ago

This seems to be a regression, but I'm not confident of the intended behavior so let me know if I'm misunderstanding

Layers l=blsat,uf

golden shows Urban Fragility atop landsat https://golden.earthtime.org/explore#v=36.14414,-115.17283,10.201,latLng&l=blsat,uf image

staging shows Urban Fragility atop dark map: https://staging.earthtime.org/explore#v=36.14414,-115.17283,10.201,latLng&l=blsat,uf image

pdille commented 3 years ago

More changes in commit ba128379

Per the discussion, paired base maps should only show if the user is manually turning them on and not when part of a share link.

Please run through the tests again! Thanks.

jjkohler commented 3 years ago

Testing indicates that this issue has been fixed.