search

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

Change dot flows (e.g. refugees, crude flows) in layers spreadsheet to Draw Order 700 #188

Closed rsargent closed 3 years ago

rsargent commented 3 years ago

More info in #187

rsargent commented 3 years ago

Need to override draw order to 700 in spreadsheet for refugee and crude flows (and other flows) as the default assigned is 600, but the design intent is draw level 700.

rsargent commented 3 years ago

To clarify, there aren't known examples where this shows a regression. It's simply that it might cause future confusion if these layers don't match the design spec.

pdille commented 3 years ago

@gabrielo While not a critical for release, would you be willing to go through the Sheets and set the draw order value for the types of layers mentioned above? I think you know best what flow layers we have and it would be good to bring closure to the draw order related topics.

pdille commented 3 years ago

@gabrielo

I was running into an issue with draw order for a point-flow type layer, so I went ahead and made the draw order changed discussed here. I modified layers that had the following draw functions. Did I miss any other flow type layers?

_drawPointFlow, _drawSitc4r2, _drawAnnualRefugees, _drawMonthlyRefugees, _drawSpCrude

gabrielo commented 3 years ago

@pdille

I think just the layers using the _drawParticles which I've updated to now as well.

jjkohler commented 3 years ago

This should be ready to close now.