CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

ps=XX not honored when visiting sharelink #200

Closed rsargent closed 3 years ago

rsargent commented 3 years ago

ps=XX appears not to be honored when visiting sharelink (but is honored when clicking on a story waypoint)

Originally reported in #192

Waypoint 72:

image

When clicking on waypoint 72 in golden vs staging, both show up as "Slow" by default and have same speeds.

Regression testing seems to instead show Medium speed for staging, as does following the regression testing link image

The link that shows medium in staging has ps=25, which should be slow, but produces medium in staging. (Similar link correctly produces slow in golden)

https://staging.earthtime.org/explore#v=39.68237,-97.4215,2.248,latLng&t=0.38&startDwell=0&endDwell=1.0ps&l=bdrk,sp&bt=19840101&et=20161231&ps=25


Waypoint 206 is due to ps=XX not being honored

https://golden.earthtime.org/explore#v=40.4479,-79.94045,10.5,latLng&t=5&ps=15&l=bdrk,bdrk_detailed,allegheny_county_pgh,anim_acs_poverty_by_race_2010_2018&bt=20100101&et=20180101&startDwell=0&endDwell=0.02 is slow and

https://staging.earthtime.org/explore#v=40.4479,-79.94045,10.5,latLng&t=5&ps=15&l=bdrk,bdrk_detailed,allegheny_county_pgh,anim_acs_poverty_by_race_2010_2018&bt=20100101&et=20180101&startDwell=0&endDwell=0.02 is too fast because ps=15 is not honored.

pdille commented 3 years ago

Fixed in commit ebf0e22

Please confirm.

rsargent commented 3 years ago

Confirmed!