CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries
Other
14 stars 5 forks source link

Smell reports with fixed bt, et do not display #230

Open rsargent opened 3 years ago

rsargent commented 3 years ago

This link: https://headless.earthtime.org/#l=bdrk_detailed,smell_my_city_pgh_reports_top&bt=20210405010000&et=20210406010000&v=40.42532,-79.91643,9.233,latLng&ps=2400&startDwell=0&endDwell=0

shows only plumes, no smell icons: image

while if we remove only the plume layer and go to: https://headless.earthtime.org/#l=bdrk_detailed,smell_my_city_pgh_reports_top&bt=20210405010000&et=20210406010000&v=40.42532,-79.91643,9.233,latLng&ps=2400&startDwell=0&endDwell=0

we see smell reports, but for a completely different time range in 2019: image

pdille commented 3 years ago

I believe the first link with the plumes is missing the plume layer ID from the URL.

That said, this is doing what is expected. The smell report layers are all defined in the spreadsheet to only be of a May 2019 time span. Technically there also is a smell layer, the no fade smell reports, that actually does goes into 2021. Taking any of the others though and pairing it with a plume layer that is outside the 2019 span will indeed not draw anything from the smell report layer. And if you turn on the smell report last, then you no longer see the plume layer and instead just see the smell reports.

I made an example layer in the davos2019 sheet that is a 2021 time span for the smell reports and it seems to do what I would expect: https://headless.earthtime.org/#l=bdrk_detailed,smell_my_city_pgh_reports_top2,plume_noburst_bugfix_final_202104050100_202104060100&bt=20210405010000&et=20210406010000&v=40.42532,-79.91643,9.233,latLng&ps=0&startDwell=0&endDwell=0

Lastly, I'm seeing a bunch of smell report layers across both the default sheet and the davos2019 sheets. I suggest consolidating to one sheet for sanity.

pdille commented 3 years ago

This is a nice reminder though to actually get the calendar working again for smell reports so that we don't need to keep updating the smell layers in the spreadsheet. #179