Sea Level Rise timelines sometimes show 1984-2016 instead of temperature

CMU-CREATE-Lab / data-visualization-tools

EarthTime, and various data visualization libraries

Other

14 stars 5 forks source link

Sea Level Rise timelines sometimes show 1984-2016 instead of temperature #93

Closed rsargent closed 4 years ago

rsargent commented 5 years ago

To reproduce, visit

https://earthtime.org/stories/internallayers#waypoints=1dxJ2YR3MFYTyZrV3MiGsm7kbOGPdvlzHL0_8HXhT7Bo.1596808134

and then click next waypoint (slr15, or page-up). Timeline will show 1984-2016 instead of temperature

rsargent commented 4 years ago

Reproduced during presentations in Jan.

pdille commented 4 years ago

Fixed in commit 76b92a8e26d Please confirm.

Technically if a base layer was included in those waypoint share links this likely would not have happened. A normal share link always includes a base layer. That said, this edge case is now handled. Eventual timeline refactor will also solve issues like this.

rsargent commented 4 years ago

Confirmed fixed! Tested at earthtime.org