CMU-CREATE-Lab / esdr

Environmental Sensor Data Repository (ESDR)
Other
12 stars 9 forks source link

Export link goes to foo.bar #20

Closed rsargent closed 3 years ago

rsargent commented 3 years ago

To reproduce:

Visit https://esdr.cmucreatelab.org/explore/#channels=3544.TEMP&plotHeight=5.000&plotAreaHeight=40.000&showSparklines=true&showFilters=true&showSettings=true&showResults=true&center=41.182594536015834,-79.0417042070809&zoom=8

Click on export button

Click on CSV

Browser tries to navigate to foo.bar

Screenshot. (For this screenshot, my mouse was hovering over the CSV link, even though the mouse isn't visible. See the URL foo.bar in the lower left)

image

rsargent commented 3 years ago

Related, JSON link goes to esdr.cmucreatelab.org/explore:

(mouse was hovering over JSON link) image

rsargent commented 3 years ago

To reproduce this for the most recent codebase,

Visit https://environmentaldata.org/#channels=1.BP_MM_HG&plotHeight=5.000&plotAreaHeight=40.000&showSparklines=true&showFilters=true&showSettings=true&showResults=true&center=45.58184804624772,-79.9959&zoom=5

Click download

Observe bad URLs for CSV and JSON

Note that if you pan or zoom even a tiny bit, the URLs look to become correct.

dognotdog commented 3 years ago

should be fixed as of e63eff7, which makes sure download links are updated when showing the download pane.

dognotdog commented 3 years ago

I was wrong, it's still out of sync if the timeline has not been moved... at least that's a clue!

dognotdog commented 3 years ago

I am hopeful 544d56a does the trick!

rsargent commented 3 years ago

Fixed, thanks!!