search

CMU-CREATE-Lab / flutter-app-android

5 stars 3 forks source link

Servo frequency relationship error #228

Open jenncross opened 6 years ago

jenncross commented 6 years ago

Servo does not move at all when "dark position" is set to 180 and "light position" is set to 0 (for light sensor).

jenncross commented 6 years ago

This is compounded/caused by the fact that the labels "dark" and "light" are fairly meaningless in the context of the oscillating relationships.

It will probably be easier to fix once #197 is implemented, allowing us to change the wizard path in accordance with the type of relationship chosen.

Blocked by #197

jenncross commented 6 years ago

Potentially fixed by new board

jenncross commented 6 years ago

Okay, after some accidental testing, I believe that the frequency relationship does not work when the "Dark" position is larger than the "Bright" position (probably because it is being treated as a max and min instead of just as two bounding endpoints).

@JSchapiro Can you please make sure that the new board is able to tolerate when the second position provided is smaller than the first position provide? (E.g. make the protocol order agnostic)

jenncross commented 6 years ago

This problem is almost certainly also the source of issue #214

This would explain, I think, why only the color element that is set in the correct order work (first setting: off/dark, second setting: on/bright)