CMU-CREATE-Lab / flutter-app-android

5 stars 3 forks source link

new servo design in wizard? #258

Closed tasota closed 6 years ago

tasota commented 6 years ago

We implemented the new servo design (#196) but the wizard designs are still using the old indicator.

Should we keep this or replace it with the new servo design?

ehamner commented 6 years ago

Parv, Tasota, and I looked at it together. The way it is working now looks nice when you move the servo slider. And the new servo indicator design would make it harder to indicate a single value, which is what you are doing in the wizard. We said let's leave it how it is for now unless we come up with a strong reason why we should change it.

jenncross commented 6 years ago

I wonder if there is a way to make the old indicator (which I agree is nice for picking a single angle) more visually similar to the new indicator.

So that is obvious for kids that the two representations are very closely related.

Some ideas (I think we should pick a couple of these to implement):

  1. Add the center "dot" from the new indicator on the old one
  2. Use the green color from the new indicator on the old one
  3. Move the 0 and 180 indicators to be inside the circle of the old indicator
  4. Make the old indicator a full circle (but gray out the bottom half)
tasota commented 6 years ago

Also worth noting that replacing this would mean we do not need #260, so I will just include that issue as dependent on the results of this issue.

tasota commented 6 years ago

What we discussed today (@jenncross scans to follow):

jenncross commented 6 years ago

img_20180718_145614

tasota commented 6 years ago

to be implemented in #265