search

CMU-MS-DAS-Modern-Programming-Mini / ClassAssignmentNo3

Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Issue with passing Travis CI #10

Open epiechow opened 3 years ago

epiechow commented 3 years ago

I am having an issue with passing the Travis CI check.

When I run pytest on my computer, everything passes the check. However after pushing to my fork and letting Travis CI run its check, it failed with one value. My ( assert mo_coeffs[0, 1] == pytest.approx(-2.33624458e-01) ) is now saying it should be positive, however it is saying it should be negative when I run pytest on my computer. Nothing else has changed between my codes. Is this an issue I can ignore with signs?

shots47s commented 3 years ago

You could test absolute values rather than the signed value.

On Wed, Oct 6, 2021 at 3:07 PM epiechow @.***> wrote:

I am having an issue with passing the Travis CI check.

When I run pytest on my computer, everything passes the check. However after pushing to my fork and letting Travis CI run its check, it failed with one value. My ( assert mo_coeffs[0, 1] == pytest.approx(-2.33624458e-01) ) is now saying it should be positive, however it is saying it should be negative when I run pytest on my computer. Nothing else has changed between my codes. Is this an issue I can ignore with signs?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CMU-MS-DAS-Modern-Programming-Mini/ClassAssignmentNo3/issues/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACL5275BAYKEEBXJVPGVLUFSM6FANCNFSM5FPOGZQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

epiechow commented 3 years ago

I ended up having to do that with two of the values, I am not sure why as that was not an issue in my own pytest. But that fixed the issue. Thank you Shawn!

shots47s commented 3 years ago

Well, keep in mind that TravsCI is not running on your laptop, the discrepancy in signs can vary from machine to machine, so that is why it is not necessarily the same answer on your laptop vs. the image that Travis is running.

On Wed, Oct 6, 2021 at 4:00 PM epiechow @.***> wrote:

I ended up having to do that with two of the values, I am not sure why as that was not an issue in my own pytest. But that fixed the issue. Thank you Shawn!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CMU-MS-DAS-Modern-Programming-Mini/ClassAssignmentNo3/issues/10#issuecomment-937023779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACL5YARW4GTPNRP7VOOBTUFSTHJANCNFSM5FPOGZQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.