search

CMU-Perceptual-Computing-Lab / caffe_train

Other
88 stars 55 forks source link

update caffe with the latest master version from BLVC #4

Open xizero00 opened 7 years ago

xizero00 commented 7 years ago

Hi all: I have update the caffe with the latest master (2017/7/26) version from BLVC. Would you please merge it? Thanks. Feng

gineshidalgo99 commented 7 years ago

EDITED: sorry, I confused the repo. I'll check it and merge it if everything works properly. Thanks!

gineshidalgo99 commented 7 years ago

I have a main concern...

Caffe removed the data_reader.hpp and data_reader.cpp files because they started to use instead the NCCL library.

However, for what I could understand after taking a look to your code, you have simply copied again the old data_reader files instead of adapting the CPM files to use the new NCCL library as Caffe does, right?

Since then we are using two different methods to parallelize the GPUs (the one the CPM files use vs. the one everything else in Caffe uses), is this completely thread safe or even single-thread safe? I am asking because I am not an expert in NCCL not Caffe data_reader, but keep using both sounds to me like a bug-prone idea...