search

CMU-Robotics-Club / RoboBuggy2

A complete re-write of the old RoboBuggy.
GNU General Public License v3.0
3 stars 0 forks source link

Sssilviaa/readme #20

Closed SSSilviaa closed 12 months ago

christianvluu commented 1 year ago

Can you also edit "Installation" section to include the steps you followed last time?

SSSilviaa commented 1 year ago

Can you also edit "Installation" section to include the steps you followed last time?

Oops. I am very sorry. If you are referring to the set up steps you so kindly helped me do last time, I barely remember all the complicated steps. But would happily edit it if we could talk it over next meeting.

christianvluu commented 1 year ago

Can you also edit "Installation" section to include the steps you followed last time?

Oops. I am very sorry. If you are referring to the set up steps you so kindly helped me do last time, I barely remember all the complicated steps. But would happily edit it if we could talk it over next meeting.

Let's talk over it next meeting. Please remind me about this.

christianvluu commented 1 year ago

@Jackack for visibility

christianvluu commented 1 year ago

Can you also remove the section on the 3D simulator. That is deprecated.

christianvluu commented 1 year ago

I think there's a way to insert those youtube videos I made into the readme directly without linking it to YouTube - that might be helpful.

christianvluu commented 1 year ago

@Jackack visibility.

SSSilviaa commented 1 year ago

Can you also remove the section on the 3D simulator. That is deprecated.

removed now

SSSilviaa commented 1 year ago

I think there's a way to insert those youtube videos I made into the readme directly without linking it to YouTube - that might be helpful.

I succeeded by half. The video can play by clicking on the image now. However, then the video fills the whole screen and cannot become small again.

christianvluu commented 1 year ago

Not sure if you're not seeing it but there's a few comments left I made above that are unresolved.

SSSilviaa commented 1 year ago

Not sure if you're not seeing it but there's a few comments left I made above that are unresolved.

Which ones? I don’t think I see them

christianvluu commented 12 months ago

Thanks for the edits. But for next time, please don't resolve these messages on your own - the idea is the reviewer who looks at them initially resolves them.