search

CMU-Robotics-Club / RoboBuggy2

A complete re-write of the old RoboBuggy.
GNU General Public License v3.0
2 stars 0 forks source link

Sw/UI velocity #38

Closed TiaSinghania closed 5 months ago

TiaSinghania commented 7 months ago

Added another subclass for Controller that launches a tkinter window. Allows user to use up and down arrow keys to increase and decrease the published velocity from 0 to 30 in increments of 0.1.

christianvluu commented 7 months ago

Just realized I accidentally used my other git account for the review... whoops (vluu23 is me)

christianvluu commented 7 months ago

Also please pull in the most recent changes from the main branch (there's CI stuff in there which will help with readability).

christianvluu commented 5 months ago

Doesn't work for me when I run with roslaunch buggy sim_2d_2buggies.launch.

What file and I supposed to run? Or what command?

Are we supposed to use X11 for the tkinter window? X11 is quite nasty for cross-platform stuff, the first version of the sim was X11 based and it was quite cumbersome to get working.

Jackack commented 5 months ago

After resolving X11 issues, was able to test on MacOS by just running the launch files. I'll put in a PR for the link to the tutorial later.

The GUI module works fine, but please edit the launch files so that the UI updater isn't run at the same time as Patrick's checkpoint-based updater. You can do this by adding a command line argument to the launch file and casing on. it, see: https://wiki.ros.org/roslaunch/XML#if_and_unless_attributes

Or, just make two versions of each of sim_2d_single/2buggies files.