CMU-Robotics-Club / RoboBuggy2

A complete re-write of the old RoboBuggy.
GNU General Public License v3.0
2 stars 0 forks source link

Auton overtake feature, as well as pylint fixes #39

Closed Jackack closed 4 months ago

Jackack commented 5 months ago

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

To test auton overtaking in sim: run sim_2d_2buggies.launch You will be able to visualize the movements of the 2 simulated buggies in Foxglove.

What you should see on the map visualization are 2 buggies. One will move faster and overtake another, staying 2 meters away at the closest.

Here's the ROSbag of the demo run: https://drive.google.com/file/d/1913GAiZg_PoAF8P0pv_pyOv-dJqz8pLd/view?usp=drive_link

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

Jackack commented 5 months ago

Due to my git rebase skill issue, the CI commit, which was merged into this branch from main, got rebased :/

A lot of the delta should be due to fixing pylint errors (trailing whitespace, import orders, etc)

Jackack commented 5 months ago

Updated PR template, feel free to check out the demo ROSbag and/or testing this code for yourself.

christianvluu commented 5 months ago

Tested this with a few scenarios on my own computer - looks good.