CMU-Robotics-Club / RoboBuggy2

A complete re-write of the old RoboBuggy.
GNU General Public License v3.0
3 stars 0 forks source link

added preroll checks and publish check status #44

Closed TiaSinghania closed 7 months ago

TiaSinghania commented 7 months ago

(stole format from patricks pr)

What type of PR is this? (check all applicable)

Description

Added additionally safety checks to autonsystem which will ensure messages are being received, RTK status is fixed, covariance is acceptable, and heading is pointing generally in the correct direction (within 180 degrees of where is should be)

QA Instructions, Screenshots, Recordings

The code still builds but hasn't been tested on the actual buggy.

christianvluu commented 7 months ago

Also add your PR comments, I have no idea what I'm supposed to be checking for without actually digging into the code.

christianvluu commented 7 months ago

Looks fine to me, haven't tested it myself so I'll defer to Jack for the approval.

Jackack commented 7 months ago

Might have to remove the RTK status check since I didn't realize that topic is not active in sim when I requested the check