search

CMU-Robotics-Club / RoboBuggy2

A complete re-write of the old RoboBuggy.
GNU General Public License v3.0
3 stars 0 forks source link

steering_angle_rate_check has a multitude of issues #92

Open mehulgoel873 opened 4 months ago

mehulgoel873 commented 4 months ago
  1. Magic Numbers, why is the threshold 100 deg/second, is this validated (we should comment the math that led to this number)
  2. This steering angle check should be run for both buggies, so the topic name should be better written
  3. Additionally, this logs to a local file, which would be unhelpful overall, and ideally all information should be stored in the bag.
  4. Have a logerr when we pass the treshold as otherwise, no one will check for this flag and its purpose will be lost.
  5. Overall validation should be a stronger suit of robobuggy software