search

CMU-SAFARI / MQSim

MQSim is a fast and accurate simulator modeling the performance of modern multi-queue (MQ) SSDs as well as traditional SATA based SSDs. MQSim faithfully models new high-bandwidth protocol implementations, steady-state SSD conditions, and the full end-to-end latency of requests in modern SSDs. It is described in detail in the FAST 2018 paper by Arash Tavakkol et al., "MQSim: A Framework for Enabling Realistic Studies of Modern Multi-Queue SSD Devices" (https://people.inf.ethz.ch/omutlu/pub/MQSim-SSD-simulation-framework_fast18.pdf)
https://people.inf.ethz.ch/omutlu/pub/MQSim-SSD-simulation-framework_fast18.pdf
MIT License
273 stars 149 forks source link

build warnings: slowdown_min and slowdown_min_reverse to large for double type #3

Closed c-w-m closed 6 years ago

c-w-m commented 6 years ago

Build warnings: src/ssd/TSU_FLIN.cpp:351:25: warning: integer constant is so large that it is unsigned double slowdown_min = 10000000000000000000, slowdown_max = 0; ^~~~~~~~ src/ssd/TSU_FLIN.cpp:378:33: warning: integer constant is so large that it is unsigned double slowdown_min_reverse = 10000000000000000000, slowdown_max_reverse = 0;


suggestion:
replace line 351:
double slowdown_min = 10000000000000000000, slowdown_max = 0;
with:
unsigned long long int slowdown_min = 10000000000000000000ULL, slowdown_max = 0ULL;

replace line 378:
double slowdown_min_reverse = 10000000000000000000, slowdown_max_reverse = 0;
with:
unsigned long long int slowdown_min_reverse = 10000000000000000000ULL, slowdown_max_reverse = 0ULL;
arashta commented 6 years ago

Thanks for the feedback. The implementation of the FLIN scheduler is not finalized yet. So, we temporarily removed it from the repository.