search

CMU-SAFARI / ramulator2

Ramulator 2.0 is a modern, modular, extensible, and fast cycle-accurate DRAM simulator. It provides support for agile implementation and evaluation of new memory system designs (e.g., new DRAM standards, emerging RowHammer mitigation techniques). Described in our paper https://people.inf.ethz.ch/omutlu/pub/Ramulator2_arxiv23.pdf
https://arxiv.org/abs/2308.11030
MIT License
251 stars 62 forks source link

Potential Incorrect Density Setting in HBM2/3 Implementation #26

Closed hwpeng closed 10 months ago

hwpeng commented 1 year ago

Encountered an error when running the 8Gb HBM2 and 3 configurations, as depicted in the screenshot:

Screenshot 2023-11-14 at 9 38 05 AM

Upon inspecting the implementation, I found https://github.com/CMU-SAFARI/ramulator2/blob/b7c70275f04126c647edb989270cc429776955d1/src/dram/impl/HBM3.cpp#L14

https://github.com/CMU-SAFARI/ramulator2/blob/b7c70275f04126c647edb989270cc429776955d1/src/dram/impl/HBM2.cpp#L14

It seems the density should be 8<<10 instead of 6<<10?

I have tested other versions of HBM2/3, and they appear to be functioning correctly.

RichardLuo79 commented 10 months ago

Hi,

Thanks for reporting this, we have fixed this in commit b05b6f6