CMUAbstract / tab

TAB reference implementations, examples, and documentation
Other
0 stars 0 forks source link

Add support for Bootloader Write Page #21

Closed mablem8 closed 1 year ago

mablem8 commented 1 year ago
ChadTaylor17 commented 1 year ago

Support tests results:

In app mode: txcmd: bootloader_write_page hw_id:0x1234 msg_id:0x0009 src:gnd dst:cdh subpage_id:1 hex_data:0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 reply: common_nack hw_id:0x1234 msg_id:0x0009 src:cdh dst:gnd

In bootloader mode: Bootloader Write Page txcmd: bootloader_write_page hw_id:0x1234 msg_id:0x0009 src:gnd dst:cdh subpage_id:1 hex_data:0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 reply: bootloader_ack hw_id:0x1234 msg_id:0x0009 src:cdh dst:gnd reason:0x01(erased)

Changes can be seen on this branch

mablem8 commented 1 year ago

Link to the commit that addresses the issue instead of the branch (since the branch will eventually be pruned after merging). In the branch, Commit 1a89e6a66f8b0c08ef26a2416ea5798d88879892 makes an implicit declaration of bootloader_write_data, which will fail at runtime. Commit 852a7284639f6c0005d5be6abd9b0bf5a461aea6 rectifies the implicit declaration but fails when testing with tx_example.py. Commit 71684fc2a2523c217c736946740f6932f2cd6cf4 rectifies the problem. Changes look good but the issue remains open while waiting on COM support.

ChadTaylor17 commented 1 year ago

Added implementation of Bootloader write page for com, seems to get stuck somewhere and needs to be debugged. Commit: fba7463941d75903d7ede66c0c31b5cc2f499320

mablem8 commented 1 year ago

Commit 1108279fb83ce179ab4c492fd3bbab1d2d52358e fixes the remaining open tasks in this issue and could use further testing.