CMUAbstract / tab

TAB reference implementations, examples, and documentation
Other
0 stars 0 forks source link

Add support for Application Set Time #24

Open mablem8 opened 1 year ago

mablem8 commented 1 year ago
ChadTaylor17 commented 1 year ago

Tests: txcmd: app_set_time hw_id:0x1234 msg_id:0x000c src:gnd dst:cdh sec:731089187 ns:946978000 reply: common_ack hw_id:0x1234 msg_id:0x000c src:cdh dst:gnd

Commit: c35549ecbb49db79a6b0fef89c653306181683ee

mablem8 commented 1 year ago

There are some issues preventing a merge of commit c35549ecbb49db79a6b0fef89c653306181683ee.

Issues with compilation

Because this commit adds external handlers for setting and getting the time in the TAB C implementation, and because these handlers have only been added to the CDH example and not the COM example, the COM example no longer compiles (i.e., a regression). When leaving a portion of the code unimplemented, be sure to add empty handlers with hard-coded success values so that the programs still compile.

Issues with attribution

Since this commit adds code written by Shize Che during the summer and fall of 2021, be sure to add his name to the contributors lists at the top of the appropriate files.

Issues with workflow

Because the proposed commit also includes a proposed fix for another issue, the proposed fix to this issue cannot be tested independently from the code aimed at the other issue. If, for example, the fix for this issue passes but the fix for the other issue fails, then the commit would be prevented from being merged despite containing a working fix.

Issues with comment formatting

When posting test results, use three ` characters to indicate the start of an output block, and use three of that same character to end the output block.

ChadTaylor17 commented 1 year ago

Commits for app set time: 509eabf3cc108a760583a64cbe9ca9df7bcde2b1 and 92daa56f210c5c401a5af72cafd414543f0995cc