CMUAbstract / tab

TAB reference implementations, examples, and documentation
Other
0 stars 0 forks source link

Update the Common Data function handler in the CDH example #4

Closed mablem8 closed 1 year ago

mablem8 commented 1 year ago

The Python TX example sends two Common Data commands.

Update the CDH example to support the expected replies.

ChadTaylor17 commented 1 year ago

I made the changes here: 1ad701d505b0ea4a42fa95477dd199d197648da0 I also tested these changes and was able to get a COMMON_ACK and COMMON_NACK: Screenshot from 2023-02-09 17-34-35

mablem8 commented 1 year ago

Nice catch, I've tested the fix and confirmed it works. Closing this issue, but the pull request should be back into the sprint-1 branch and not the master branch.