CMUAbstract / tab

TAB reference implementations, examples, and documentation
Other
0 stars 0 forks source link

Add support for Bootloader Ack #8

Closed mablem8 closed 1 year ago

mablem8 commented 1 year ago
ChadTaylor17 commented 1 year ago

Commit: 59cf88fcbd4d79489a0c1190771290e33e0bdc95

Tested successfully: txcmd: bootloader_ack hw_id:0x1234 msg_id:0x0005 src:gnd dst:cdh reply: common_nack hw_id:0x1234 msg_id:0x0005 src:cdh dst:gnd

mablem8 commented 1 year ago

For future posts, link to the changes that address each issue bullet:

ChadTaylor17 commented 1 year ago

Commit: 5492cab8fc3490dec43c11aa1838b0532f04443f

For "Bootloader Ack does not have length 6": It should be length 6 since that is done for transmitting the command. Because the reason is an optional parameter, when we are transmitting the command which should not happen, the optional parameter is not used, therefore the length is 6.

mablem8 commented 1 year ago

This commit looks good!

When submitting an Issue fix, use the following format:

txcmd: bootloader_ack hw_id:0x1234 msg_id:0x0005 src:gnd dst:cdh
reply: common_nack hw_id:0x1234 msg_id:0x0005 src:cdh dst:gnd